Fix request/response with addresses #3145
Merged
+51
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While previous version worked, it didn't behave nicely during concurrent requests to the same peer due to lack of awareness of pending requests, resulting in this:
While I could fix that with more hacks, I decided to simply patch libp2p while we're discussing it in libp2p/rust-libp2p#5634, here is the patch (
subspace-v8
branch): autonomys/rust-libp2p@ae75274Patch adds
addresses
argument tosend_request
method, fixing this issue.Code contributor checklist: